Viewing files at commit 1c9b819ab86bCommit detailsView latest

Browse files
tests/test_agent_campaign_cli.py 284 lines · 15.7 KB · python
1
"""Independent CLI integration: real Git, mock agent, durable campaign records."""
2
from pathlib import Path
3
import json
4
import shutil
5
import subprocess
6
import sys
7
import tempfile
8
import unittest
9
10
11
ROOT = Path(__file__).resolve().parents[1]
12
CLI = ROOT / "scripts" / "agent_campaign.py"
13
14
15
@unittest.skipUnless(shutil.which("git"), "Git is required for the campaign integration")
16
class CampaignCLIIntegrationTests(unittest.TestCase):
17
    def setUp(self):
18
        self.temp = tempfile.TemporaryDirectory(prefix="oakbench-campaign-cli-")
19
        self.addCleanup(self.temp.cleanup)
20
        self.root = Path(self.temp.name).resolve()
21
        self.campaign = self.root / "campaign"
22
        self.agents = self.root / "agents.toml"
23
        self.agents.write_text('[agents.mock]\nenabled = true\nadapter = "deterministic_mock"\nprovider = "local"\n')
24
        self.subjects = self.root / "subjects.toml"
25
        self.subjects.write_text('[subjects.git]\nenabled = true\nkind = "git"\nlabel = "Git"\nbin = '
26
                                 + json.dumps(shutil.which("git")) + '\n')
27
        self.manifest = self.root / "manifest.json"
28
        self.manifest.write_text(json.dumps({
29
            "schema_version": 1, "campaign_id": "cli-integration",
30
            "agents_config": str(self.agents), "subjects_config": str(self.subjects),
31
            "agents": [{"name": "mock", "model": None}], "subjects": ["git"],
32
            "workflows": ["wide_config_refactor"], "instruction_levels": ["cheat-sheet"],
33
            "repetitions": 2, "seed": 194, "max_trials": 2, "max_wall_seconds": 180,
34
            "trial_timeout_seconds": 30, "track": "agent-default", "agent_environment": "minimal",
35
        }))
36
37
    def invoke(self, command, *args):
38
        return subprocess.run([sys.executable, str(CLI), command,
39
                               "--campaign-dir", str(self.campaign), *args],
40
                              cwd=ROOT, text=True, capture_output=True, timeout=120)
41
42
    def plan(self):
43
        result = self.invoke("plan", "--manifest", str(self.manifest))
44
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
45
        return json.loads((self.campaign / "plan.json").read_text())
46
47
    def fixture_hash(self, plan):
48
        sys.path.insert(0, str(ROOT / "scripts"))
49
        from oakbench import agent_campaign
50
        import workflow_ab
51
        agent_campaign.cached_fixture(self.campaign, plan, workflow_ab.WORKFLOWS["wide_config_refactor"])
52
        record = json.loads((self.campaign / "fixture-integrity/wide_config_refactor.json").read_text())
53
        return agent_campaign.digest(record["manifest"])
54
55
    def events(self):
56
        return [json.loads(line) for line in (self.campaign / "events.jsonl").read_text().splitlines()]
57
58
    def test_real_git_mock_completion_and_noop_resume_preserve_evidence(self):
59
        plan = self.plan()
60
        self.assertEqual(len(plan["schedule"]), 2)
61
        result = self.invoke("run")
62
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
63
        self.assertEqual(json.loads(result.stdout)["finished"], 2)
64
        self.assertIn("[trial]", result.stderr)
65
        events = self.events()
66
        self.assertEqual([event["event"] for event in events], ["started", "finished"] * 2)
67
        finished = [event for event in events if event["event"] == "finished"]
68
        for event in finished:
69
            self.assertTrue(event["row"]["success"], event)
70
            self.assertTrue(event["row"]["success_criteria"]["checks"]["required_checks_passed"])
71
            self.assertEqual(event["row"]["task_id"], event["trial_id"])
72
        journal = (self.campaign / "events.jsonl").read_bytes()
73
        # Simulate the crash window after the authoritative terminal fsync but
74
        # before refreshing the derived rows. Resume must repair this view.
75
        (self.campaign / "rows.jsonl").write_text("")
76
        shutil.rmtree(self.campaign / "fixtures")
77
        shutil.rmtree(self.campaign / "fixture-integrity")
78
        result = self.invoke("resume")
79
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
80
        self.assertEqual((self.campaign / "events.jsonl").read_bytes(), journal)
81
        self.assertFalse((self.campaign / "fixtures").exists())
82
        recovered = [json.loads(line) for line in (self.campaign / "rows.jsonl").read_text().splitlines()]
83
        self.assertEqual(recovered, [event["row"] for event in finished])
84
        result = self.invoke("report")
85
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
86
        self.assertIn('"claim_eligible": false', result.stdout.lower())
87
88
    @unittest.skipUnless(shutil.which("oak"), "Oak is required for the default Git-vs-Oak report")
89
    def test_default_git_vs_oak_campaign_report_renders_with_refused_pairs(self):
90
        # Default configuration: no byte-distinct Git instrument and no
91
        # independent Oak reader, so Git rows carry subject_binary_* evidence
92
        # and Oak rows subject_produced_*. The report must refuse those pairs,
93
        # never crash (regression: ValueError -> exit 2, no report).
94
        self.subjects.write_text(self.subjects.read_text() + '[subjects.oak_installed]\nenabled = true\nkind = "oak"\n'
95
                                 'label = "Oak"\nbin = ' + json.dumps(shutil.which("oak")) + '\n')
96
        manifest = json.loads(self.manifest.read_text())
97
        manifest.update(subjects=["git", "oak_installed"], repetitions=1, max_trials=2)
98
        self.manifest.write_text(json.dumps(manifest))
99
        self.plan()
100
        result = self.invoke("run")
101
        self.assertIn(result.returncode, (0, 1), result.stdout + result.stderr)
102
        classes = {event["row"]["subject"]: event["row"].get("workflow_integrity_evidence_class")
103
                   for event in self.events() if event["event"] == "finished" and isinstance(event.get("row"), dict)}
104
        for fmt in ("json", "markdown"):
105
            report = self.invoke("report", "--format", fmt)
106
            self.assertEqual(report.returncode, 0, report.stdout + report.stderr)
107
        summary = json.loads(self.invoke("report").stdout)
108
        pair = summary["groups"][0]["paired_comparisons"][0]
109
        if len(set(classes.values())) > 1 and all(event["row"]["success"] for event in self.events()
110
                                                   if event["event"] == "finished" and isinstance(event.get("row"), dict)):
111
            self.assertTrue(pair["comparison_refused"], (classes, pair))
112
            self.assertIn("workflow_integrity_evidence_class", pair["incompatible_evidence_fields"])
113
            self.assertIn("paired_evidence_incompatible", summary["claim_ineligibility_reasons"])
114
115
    def test_corrupted_cache_resume_is_preflight_error_preserving_pending(self):
116
        self.plan()
117
        first = self.invoke("run", "--limit", "1")
118
        self.assertEqual(first.returncode, 3, first.stderr)
119
        journal = (self.campaign / "events.jsonl").read_bytes()
120
        payload = next((self.campaign / "fixtures/wide_config_refactor").glob("services/*/config.toml"))
121
        payload.chmod(0o600)
122
        payload.write_text("changed cached initial state")
123
        result = self.invoke("resume")
124
        self.assertEqual(result.returncode, 2, result.stdout + result.stderr)
125
        self.assertIn("fixture content drift", result.stderr)
126
        self.assertEqual((self.campaign / "events.jsonl").read_bytes(), journal)
127
        status = self.invoke("status")
128
        self.assertEqual(len(json.loads(status.stdout)["pending_trial_ids"]), 1)
129
130
    def test_cache_and_record_rewrite_cannot_rebind_prior_trial_input(self):
131
        import hashlib
132
        self.plan()
133
        first = self.invoke("run", "--limit", "1")
134
        self.assertEqual(first.returncode, 3, first.stderr)
135
        journal = (self.campaign / "events.jsonl").read_bytes()
136
        fixture = self.campaign / "fixtures/wide_config_refactor"
137
        payload = next(fixture.glob("services/*/config.toml"))
138
        payload.chmod(0o600)
139
        payload.write_bytes(b"changed baseline plus forged cache record")
140
        record_path = self.campaign / "fixture-integrity/wide_config_refactor.json"
141
        record = json.loads(record_path.read_text())
142
        entry = record["manifest"][payload.relative_to(fixture).as_posix()]
143
        entry.update(size=len(payload.read_bytes()), sha256=hashlib.sha256(payload.read_bytes()).hexdigest())
144
        record_path.write_text(json.dumps(record))
145
        result = self.invoke("resume")
146
        self.assertEqual(result.returncode, 2, result.stdout + result.stderr)
147
        self.assertIn("journal fixture binding", result.stderr)
148
        self.assertEqual((self.campaign / "events.jsonl").read_bytes(), journal)
149
        status = self.invoke("status")
150
        self.assertEqual(len(json.loads(status.stdout)["pending_trial_ids"]), 1)
151
152
    def test_incomplete_generation_fails_before_any_admission(self):
153
        self.plan()
154
        fixture = self.campaign / "fixtures/wide_config_refactor"
155
        fixture.mkdir(parents=True)
156
        (fixture / "partial").write_text("crashed generation")
157
        result = self.invoke("run")
158
        self.assertEqual(result.returncode, 2, result.stdout + result.stderr)
159
        self.assertIn("fixture cache is incomplete", result.stderr)
160
        self.assertFalse((self.campaign / "events.jsonl").exists())
161
        status = self.invoke("status")
162
        self.assertEqual(len(json.loads(status.stdout)["pending_trial_ids"]), 2)
163
164
    def test_existing_plan_and_changed_config_fail_before_agent_execution(self):
165
        self.plan()
166
        frozen = (self.campaign / "plan.json").read_bytes()
167
        result = self.invoke("plan", "--manifest", str(self.manifest))
168
        self.assertNotEqual(result.returncode, 0)
169
        self.assertEqual((self.campaign / "plan.json").read_bytes(), frozen)
170
        self.agents.write_text(self.agents.read_text() + "\n# changed configuration\n")
171
        result = self.invoke("run")
172
        self.assertNotEqual(result.returncode, 0)
173
        self.assertFalse((self.campaign / "events.jsonl").exists())
174
175
    def test_torn_journal_cannot_be_discarded_to_retry_a_trial(self):
176
        plan = self.plan()
177
        started = {"event": "started", "trial_id": plan["schedule"][0]["trial_id"],
178
                   "plan_sha256": plan["plan_sha256"], "timeout_seconds": 30,
179
                   "ordinal": 0, "timestamp_utc": "2026-09-10T00:00:00Z",
180
                   "fixture_manifest_sha256": self.fixture_hash(plan)}
181
        journal = json.dumps(started).encode() + b"\n" + b'{"event":"finished"'
182
        (self.campaign / "events.jsonl").write_bytes(journal)
183
        result = self.invoke("resume")
184
        self.assertEqual(result.returncode, 2)
185
        self.assertIn("--acknowledge-torn-journal", result.stderr)
186
        self.assertEqual((self.campaign / "events.jsonl").read_bytes(), journal)
187
        self.assertFalse((self.campaign / "trials").exists())
188
189
    def test_impossible_budget_is_rejected_before_frozen_plan(self):
190
        manifest = json.loads(self.manifest.read_text())
191
        manifest["max_wall_seconds"] = 0.15
192
        self.manifest.write_text(json.dumps(manifest))
193
        result = self.invoke("plan", "--manifest", str(self.manifest))
194
        self.assertEqual(result.returncode, 2, result.stdout + result.stderr)
195
        self.assertIn("must admit at least one", result.stderr)
196
        self.assertFalse(self.campaign.exists())
197
198
    def test_remaining_budget_stops_without_shortening_timeout(self):
199
        plan = self.plan()
200
        started = {"event": "started", "trial_id": plan["schedule"][0]["trial_id"],
201
                   "plan_sha256": plan["plan_sha256"], "timeout_seconds": 30,
202
                   "fixture_manifest_sha256": self.fixture_hash(plan)}
203
        finished = {**started, "event": "finished", "outcome": "error", "wall_seconds": 179.85}
204
        (self.campaign / "events.jsonl").write_text(json.dumps(started) + "\n" + json.dumps(finished) + "\n")
205
        result = self.invoke("resume")
206
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
207
        state = json.loads(result.stdout)
208
        self.assertEqual(state["stopped_reason"], "insufficient_budget_for_frozen_trial_timeout")
209
        self.assertEqual(len(state["pending_trial_ids"]), 1)
210
        self.assertEqual(len(self.events()), 2)
211
212
    def test_torn_start_readonly_and_acknowledged_recovery_never_retries(self):
213
        plan = self.plan()
214
        interrupted = plan["schedule"][0]["trial_id"]
215
        raw = b'{"event":"started","trial_id":'
216
        journal = self.campaign / "events.jsonl"
217
        journal.write_bytes(raw)
218
        for command in ("status", "report"):
219
            result = self.invoke(command)
220
            self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
221
            evidence = json.loads(result.stdout)
222
            self.assertFalse(evidence["journal_recoveries"][0]["acknowledged"])
223
            self.assertEqual(journal.read_bytes(), raw)
224
        result = self.invoke("resume", "--acknowledge-torn-journal")
225
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
226
        events = self.events()
227
        self.assertEqual(events[0]["trial_id"], interrupted)
228
        self.assertTrue(events[0]["uncertain_torn_start"])
229
        marker = events[1]
230
        self.assertTrue(marker["acknowledged"])
231
        self.assertEqual((self.campaign / marker["archive"]).read_bytes(), raw)
232
        self.assertFalse((self.campaign / "trials" / interrupted).exists())
233
        self.assertEqual(len([e for e in events if e["event"] == "finished"]), 1)
234
        result = self.invoke("resume")
235
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
236
        self.assertEqual(self.events(), events)
237
238
    def test_valid_digest_malformed_plan_exits_contract_error(self):
239
        import hashlib
240
        self.campaign.mkdir()
241
        malformed = {"schema_version": 1}
242
        malformed["plan_sha256"] = hashlib.sha256(b'{"schema_version":1}').hexdigest()
243
        (self.campaign / "plan.json").write_text(json.dumps(malformed))
244
        result = self.invoke("status")
245
        self.assertEqual(result.returncode, 2)
246
        self.assertIn("invalid frozen plan", result.stderr)
247
        self.assertNotIn("Traceback", result.stderr)
248
249
    def test_bounded_invocation_resumes_only_remaining_trial(self):
250
        self.plan()
251
        result = self.invoke("run", "--limit", "1")
252
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
253
        first = self.events()
254
        self.assertEqual(len(first), 2)
255
        self.assertTrue(first[1]["row"]["success"], first[1])
256
        result = self.invoke("resume", "--limit", "1")
257
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
258
        self.assertEqual(self.events()[:2], first)
259
        self.assertEqual(len(self.events()), 4)
260
261
    def test_interrupted_attempt_stays_visible_after_remaining_trial_runs(self):
262
        plan = self.plan()
263
        interrupted = plan["schedule"][0]["trial_id"]
264
        started = {"event": "started", "trial_id": interrupted,
265
                   "plan_sha256": plan["plan_sha256"], "timeout_seconds": 30,
266
                   "ordinal": 0, "timestamp_utc": "2026-09-10T00:00:00Z",
267
                   "fixture_manifest_sha256": self.fixture_hash(plan)}
268
        (self.campaign / "events.jsonl").write_text(json.dumps(started) + "\n")
269
        result = self.invoke("resume")
270
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
271
        events = self.events()
272
        self.assertEqual(len(events), 3)
273
        self.assertEqual(events[0], started)
274
        self.assertNotEqual(events[-1]["trial_id"], interrupted)
275
        self.assertTrue(events[-1]["row"]["success"], events[-1])
276
        self.assertFalse((self.campaign / "trials" / interrupted).exists())
277
        result = self.invoke("report", "--format", "json")
278
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
279
        counts = json.loads(result.stdout)["counts"]
280
        self.assertEqual((counts["started"], counts["success"], counts["interrupted"]), (2, 1, 1))
281
282
283
if __name__ == "__main__":
284
    unittest.main()