Viewing files at commit 2310099b696dCommit detailsView latest

Browse files
tests/test_agent_campaign_cli.py 182 lines · 9.4 KB · python
1
"""Independent CLI integration: real Git, mock agent, durable campaign records."""
2
from pathlib import Path
3
import json
4
import shutil
5
import subprocess
6
import sys
7
import tempfile
8
import unittest
9
10
11
ROOT = Path(__file__).resolve().parents[1]
12
CLI = ROOT / "scripts" / "agent_campaign.py"
13
14
15
@unittest.skipUnless(shutil.which("git"), "Git is required for the campaign integration")
16
class CampaignCLIIntegrationTests(unittest.TestCase):
17
    def setUp(self):
18
        self.temp = tempfile.TemporaryDirectory(prefix="oakbench-campaign-cli-")
19
        self.addCleanup(self.temp.cleanup)
20
        self.root = Path(self.temp.name).resolve()
21
        self.campaign = self.root / "campaign"
22
        self.agents = self.root / "agents.toml"
23
        self.agents.write_text('[agents.mock]\nenabled = true\nadapter = "deterministic_mock"\nprovider = "local"\n')
24
        self.subjects = self.root / "subjects.toml"
25
        self.subjects.write_text('[subjects.git]\nenabled = true\nkind = "git"\nlabel = "Git"\nbin = '
26
                                 + json.dumps(shutil.which("git")) + '\n')
27
        self.manifest = self.root / "manifest.json"
28
        self.manifest.write_text(json.dumps({
29
            "schema_version": 1, "campaign_id": "cli-integration",
30
            "agents_config": str(self.agents), "subjects_config": str(self.subjects),
31
            "agents": [{"name": "mock", "model": None}], "subjects": ["git"],
32
            "workflows": ["wide_config_refactor"], "instruction_levels": ["cheat-sheet"],
33
            "repetitions": 2, "seed": 194, "max_trials": 2, "max_wall_seconds": 180,
34
            "trial_timeout_seconds": 30, "track": "agent-default", "agent_environment": "minimal",
35
        }))
36
37
    def invoke(self, command, *args):
38
        return subprocess.run([sys.executable, str(CLI), command,
39
                               "--campaign-dir", str(self.campaign), *args],
40
                              cwd=ROOT, text=True, capture_output=True, timeout=120)
41
42
    def plan(self):
43
        result = self.invoke("plan", "--manifest", str(self.manifest))
44
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
45
        return json.loads((self.campaign / "plan.json").read_text())
46
47
    def events(self):
48
        return [json.loads(line) for line in (self.campaign / "events.jsonl").read_text().splitlines()]
49
50
    def test_real_git_mock_completion_and_noop_resume_preserve_evidence(self):
51
        plan = self.plan()
52
        self.assertEqual(len(plan["schedule"]), 2)
53
        result = self.invoke("run")
54
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
55
        events = self.events()
56
        self.assertEqual([event["event"] for event in events], ["started", "finished"] * 2)
57
        finished = [event for event in events if event["event"] == "finished"]
58
        for event in finished:
59
            self.assertTrue(event["row"]["success"], event)
60
            self.assertTrue(event["row"]["success_criteria"]["checks"]["required_checks_passed"])
61
            self.assertEqual(event["row"]["task_id"], event["trial_id"])
62
        journal = (self.campaign / "events.jsonl").read_bytes()
63
        # Simulate the crash window after the authoritative terminal fsync but
64
        # before refreshing the derived rows. Resume must repair this view.
65
        (self.campaign / "rows.jsonl").write_text("")
66
        result = self.invoke("resume")
67
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
68
        self.assertEqual((self.campaign / "events.jsonl").read_bytes(), journal)
69
        recovered = [json.loads(line) for line in (self.campaign / "rows.jsonl").read_text().splitlines()]
70
        self.assertEqual(recovered, [event["row"] for event in finished])
71
        result = self.invoke("report")
72
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
73
        self.assertIn('"claim_eligible": false', result.stdout.lower())
74
75
    def test_existing_plan_and_changed_config_fail_before_agent_execution(self):
76
        self.plan()
77
        frozen = (self.campaign / "plan.json").read_bytes()
78
        result = self.invoke("plan", "--manifest", str(self.manifest))
79
        self.assertNotEqual(result.returncode, 0)
80
        self.assertEqual((self.campaign / "plan.json").read_bytes(), frozen)
81
        self.agents.write_text(self.agents.read_text() + "\n# changed configuration\n")
82
        result = self.invoke("run")
83
        self.assertNotEqual(result.returncode, 0)
84
        self.assertFalse((self.campaign / "events.jsonl").exists())
85
86
    def test_torn_journal_cannot_be_discarded_to_retry_a_trial(self):
87
        plan = self.plan()
88
        started = {"event": "started", "trial_id": plan["schedule"][0]["trial_id"],
89
                   "plan_sha256": plan["plan_sha256"], "timeout_seconds": 30,
90
                   "ordinal": 0, "timestamp_utc": "2026-09-10T00:00:00Z"}
91
        journal = json.dumps(started).encode() + b"\n" + b'{"event":"finished"'
92
        (self.campaign / "events.jsonl").write_bytes(journal)
93
        result = self.invoke("resume")
94
        self.assertEqual(result.returncode, 2)
95
        self.assertIn("--acknowledge-torn-journal", result.stderr)
96
        self.assertEqual((self.campaign / "events.jsonl").read_bytes(), journal)
97
        self.assertFalse((self.campaign / "trials").exists())
98
99
    def test_insufficient_budget_stops_without_shortening_timeout(self):
100
        manifest = json.loads(self.manifest.read_text())
101
        manifest["max_wall_seconds"] = 0.15
102
        self.manifest.write_text(json.dumps(manifest))
103
        self.plan()
104
        result = self.invoke("run")
105
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
106
        state = json.loads(result.stdout)
107
        self.assertEqual(state["stopped_reason"], "insufficient_budget_for_frozen_trial_timeout")
108
        self.assertEqual(len(state["pending_trial_ids"]), 2)
109
        self.assertFalse((self.campaign / "events.jsonl").exists())
110
111
    def test_torn_start_readonly_and_acknowledged_recovery_never_retries(self):
112
        plan = self.plan()
113
        interrupted = plan["schedule"][0]["trial_id"]
114
        raw = b'{"event":"started","trial_id":'
115
        journal = self.campaign / "events.jsonl"
116
        journal.write_bytes(raw)
117
        for command in ("status", "report"):
118
            result = self.invoke(command)
119
            self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
120
            evidence = json.loads(result.stdout)
121
            self.assertFalse(evidence["journal_recoveries"][0]["acknowledged"])
122
            self.assertEqual(journal.read_bytes(), raw)
123
        result = self.invoke("resume", "--acknowledge-torn-journal")
124
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
125
        events = self.events()
126
        self.assertEqual(events[0]["trial_id"], interrupted)
127
        self.assertTrue(events[0]["uncertain_torn_start"])
128
        marker = events[1]
129
        self.assertTrue(marker["acknowledged"])
130
        self.assertEqual((self.campaign / marker["archive"]).read_bytes(), raw)
131
        self.assertFalse((self.campaign / "trials" / interrupted).exists())
132
        self.assertEqual(len([e for e in events if e["event"] == "finished"]), 1)
133
        result = self.invoke("resume")
134
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
135
        self.assertEqual(self.events(), events)
136
137
    def test_valid_digest_malformed_plan_exits_contract_error(self):
138
        import hashlib
139
        self.campaign.mkdir()
140
        malformed = {"schema_version": 1}
141
        malformed["plan_sha256"] = hashlib.sha256(b'{"schema_version":1}').hexdigest()
142
        (self.campaign / "plan.json").write_text(json.dumps(malformed))
143
        result = self.invoke("status")
144
        self.assertEqual(result.returncode, 2)
145
        self.assertIn("invalid frozen plan", result.stderr)
146
        self.assertNotIn("Traceback", result.stderr)
147
148
    def test_bounded_invocation_resumes_only_remaining_trial(self):
149
        self.plan()
150
        result = self.invoke("run", "--limit", "1")
151
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
152
        first = self.events()
153
        self.assertEqual(len(first), 2)
154
        self.assertTrue(first[1]["row"]["success"], first[1])
155
        result = self.invoke("resume", "--limit", "1")
156
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
157
        self.assertEqual(self.events()[:2], first)
158
        self.assertEqual(len(self.events()), 4)
159
160
    def test_interrupted_attempt_stays_visible_after_remaining_trial_runs(self):
161
        plan = self.plan()
162
        interrupted = plan["schedule"][0]["trial_id"]
163
        started = {"event": "started", "trial_id": interrupted,
164
                   "plan_sha256": plan["plan_sha256"], "timeout_seconds": 30,
165
                   "ordinal": 0, "timestamp_utc": "2026-09-10T00:00:00Z"}
166
        (self.campaign / "events.jsonl").write_text(json.dumps(started) + "\n")
167
        result = self.invoke("resume")
168
        self.assertEqual(result.returncode, 3, result.stdout + result.stderr)
169
        events = self.events()
170
        self.assertEqual(len(events), 3)
171
        self.assertEqual(events[0], started)
172
        self.assertNotEqual(events[-1]["trial_id"], interrupted)
173
        self.assertTrue(events[-1]["row"]["success"], events[-1])
174
        self.assertFalse((self.campaign / "trials" / interrupted).exists())
175
        result = self.invoke("report", "--format", "json")
176
        self.assertEqual(result.returncode, 0, result.stdout + result.stderr)
177
        counts = json.loads(result.stdout)["counts"]
178
        self.assertEqual((counts["started"], counts["success"], counts["interrupted"]), (2, 1, 1))
179
180
181
if __name__ == "__main__":
182
    unittest.main()