Commit 024e1300
024e1300bf2dMerged
Maxence Lecanu <[email protected]> · 4 months ago · 1 file · ~1 modified
Description
refactor(plugins): make colorize enablement a getter
Address review feedback: fold the standalone _colorEnabled function into a private getter on HellogColorizeDefaultPlugin.
Co-Authored-By: Claude Opus 4.8 [email protected]
Details
- Commit
- 024e1300bf2d
- Parent
- 63162cbd10e2
lib/plugins.tsmodifiedView file
@@ -145,14 +145,6 @@
145145
enabled?: boolean;146146
}147147
148-
function _colorEnabled(options: HellogColorizeDefaultPluginOptions | undefined): boolean {149-
if (options?.enabled !== undefined) return options.enabled;150-
if (process.env['FORCE_COLOR'] === '1') return true;151-
if (process.env['FORCE_COLOR'] === '0') return false;152-
if (process.env['NO_COLOR'] !== undefined) return false;153-
return process.stdout.isTTY === true;154-
}155-
156148
export class HellogColorizeDefaultPlugin extends HellogPlugin {157149
private readonly options: HellogColorizeDefaultPluginOptions | undefined;158150
@@ -161,8 +153,16 @@
161153
this.options = options;162154
}163155
156+
private get colorEnabled(): boolean {157+
if (this.options?.enabled !== undefined) return this.options.enabled;158+
if (process.env['FORCE_COLOR'] === '1') return true;159+
if (process.env['FORCE_COLOR'] === '0') return false;160+
if (process.env['NO_COLOR'] !== undefined) return false;161+
return process.stdout.isTTY === true;162+
}163+
164164
override format(messages: HellogMessage[]): HellogMessage[] {165-
if (!_colorEnabled(this.options)) return messages;165+
if (!this.colorEnabled) return messages;166166
167167
const formatted: HellogMessage[] = [];168168